Skip to content

test: ExternalPDP (2)#40055

Merged
KevLehman merged 2 commits intofeat/externalpdpfrom
test/externalpdp-2
Apr 7, 2026
Merged

test: ExternalPDP (2)#40055
KevLehman merged 2 commits intofeat/externalpdpfrom
test/externalpdp-2

Conversation

@KevLehman
Copy link
Copy Markdown
Member

@KevLehman KevLehman commented Apr 6, 2026 •
edited by coderabbitai bot
Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Chores
    • Updated CI workflow to enable profile-based service selection for API-specific end-to-end tests.
    • Simplified mock server deployment by migrating from local build to prebuilt image, reducing build complexity.

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 6, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ccdc4f58-05a9-4018-b9f0-5b4511a40a63

📥 Commits

Reviewing files that changed from the base of the PR and between e339562 and 664d1c4.

📒 Files selected for processing (5)
  • .github/workflows/ci-test-e2e.yml
  • development/mockServer/Dockerfile
  • development/mockServer/go.mod
  • development/mockServer/main.go
  • docker-compose-ci.yml

Walkthrough

The pull request removes the local mock-server implementation (Go source, module file, and Dockerfile) and replaces it with a prebuilt Docker image. The Docker Compose configuration is updated to use the external image and add profile-based control, while the CI workflow is modified to conditionally enable the mock-server via the api profile.

Changes

Cohort / File(s) Summary
Mock Server Local Implementation Removal
development/mockServer/Dockerfile, development/mockServer/go.mod, development/mockServer/main.go		 Deleted local mock server implementation including multi-stage Docker build, Go module configuration, and HTTP server code (361 lines removed).
Docker Compose Configuration Update
docker-compose-ci.yml		 Changed mock-server service from local build to prebuilt image (kaleman14/mockserver:latest) and added profiles: - api restriction for conditional service startup.
CI Workflow Update
.github/workflows/ci-test-e2e.yml		 Added conditional COMPOSE_PROFILES environment variable that sets it to 'api' when inputs.type equals 'api' to control Docker Compose profile selection.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

type: chore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 6, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 664d1c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.37%. Comparing base (e339562) to head (664d1c4).
⚠️ Report is 1 commits behind head on feat/externalpdp.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           feat/externalpdp   #40055      +/-   ##
====================================================
- Coverage             70.40%   70.37%   -0.03%     
====================================================
  Files                  3270     3270              
  Lines                117064   117064              
  Branches              21167    21119      -48     
====================================================
- Hits                  82416    82389      -27     
- Misses                32589    32610      +21     
- Partials               2059     2065       +6
Flag Coverage Δ
unit 70.72% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

KevLehman
KevLehman commented Apr 7, 2026
View reviewed changes
@KevLehman KevLehman marked this pull request as ready for review April 7, 2026 01:15
@KevLehman KevLehman requested a review from a team as a code owner April 7, 2026 01:15
@KevLehman KevLehman merged commit e8a0abb into feat/externalpdp Apr 7, 2026
41 of 44 checks passed
@KevLehman KevLehman deleted the test/externalpdp-2 branch April 7, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@KevLehman
⚡